Repository navigation
Fix LSP dialyzer errors due to invalid Clock type - #1604
Merged
Merged
Conversation
Define a `t()` type for the `Clock` struct, and use it in the function signatures. Just specifying module name ends up with LSP dialyzer errors
Contributor
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
angelikatyborska
approved these changes
Nov 15, 2025
angelikatyborska
left a comment
angelikatyborska
left a comment
Member
There was a problem hiding this comment.
Thank you very much! 🙌 We do have a dialyzer check running on CI, but it only checks example solutions, not the empty stub files. And for this exercise, those two happened to have an inconsistent approach to type annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a
t()type for theClockstruct, and use it in the function signatures to fix LSP dialyzer errors. Just using the module name in place of a struct isn't valid in this situation.